This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a lot of the cleaning scripts in many of the
package.json
do not work on Windows due to them running therm
command. This would work in PowerShell but not incmd
which is what Node seems to use to run scripts defined inpackage.json
.As an example, this leads to these errors when running the initial
yarn run bootstrap
:Before
Notice all the
'rm' is not recognized as an internal or external command
lines leading to the commands returning error code 1.I suggest using the rimraf package for these cleanups to render them platform independent.
With this change we get no errors when we run the clean scripts:
After