Changeset 44165

Timestamp:

12/14/2018 05:11:14 AM (6 years ago)

Author:

pento

Message:

Editor: Merge some minor bug fixes.

There were some tweaks made to the post editor in WordPress 5.0 that hadn't been merged to trunk, this commit rectifies that.

Merges [43815,43816] from the 5.0 branch to trunk.

Props birgire, jorbin, abdullahramzan, adamsilverstein, mrahmadawais, airathalitov, ajitbohra, schlessera, albertomedina, aldavigdis, alexsanford1, xyfi, nitrajka, afercia, andreiglingeanu, euthelup, aduth, sumobi, anevins, azaozz, androb, andrewserong, kallehauge, nosolosw, apeatling, atimmer, arnaudban, asvinballoo, b-07, benlk, blowery, caxco93, benjamin_zekavica, kau-boy, bernhard-reiter, bcolumbia, bph, boblinthorst, bradyvercher, bpayton, brentswisher, bronsonquick, burhandodhy, icaleb, chouby, ehg, chrisvanpatten, butimnoexpert, christophherr, chriskmnds, claudiosanches, danielbachhuber, mrmadhat, danielhw, danieltj, goldsounds, dfangstrom, daniloercoli, dannycooper, nerrad, dsawardekar, davemoran118, davidherrera, dryanpress, davidsword, davisshaver, dmsnell, dlocc, diegoreymendez, dd32, dency, ocean90, donnapep, chopinbach, electricfeet, eliorivero, sewmyheadon, ericnmurphy, foobar4u, circlecube, fabs_pim, flixos90, floriansimeth, gma992, garrett-eclipse, garyj, pento, doomwaxer, revgeorge, gziolo, bordoni, hardeepasrani, helen, luehrsen, herbmiller, toro_unit, ianbelanger, iandunn, igorsch, ipstenu, ireneyoast, israelshmueli, sisanu, jd55, copons, jnylen0, jamestryon, ephoxjames, jamiehalvorson, jsnajdr, jagnew, dciso, octalmage, vengisss, jhoffm34, shenkj, audrasjb, jblz, jeremyfelt, motleydev, jipmoors, sephsekla, joemaller, joemcgill, joen, johndyer, johnjamesjacoby, joshuawold, johnny5, desrosj, jonsurrell, belcherj, sirjonathan, koke, jorgefilipecosta, shelob9, jvisick77, julienmelissas, kopepasah, kadamwhite, codebykat, ryelle, gwwar, kevinwhoffman, coderkevin, ixkaito, kjellr, obenland, lancewillett, postphotos, loicblascos, lucasstark, luigipulcini, lucaskowalski, lukepettway, mahdiyazdani, mahmoudsaeed, mkaz, tyxla, markjaquith, mapk, vindl, m-e-h, mboynes, mattheu, lonelyvegan, mtias, napy84, maurobringolf, maximebj, mayukojpn, woodent, michaelhull, mmtr86, stubgo, simison, mihai2u, mike-haydon-swo, mnelson4, mpheasant, mikeschroder, idpokute, mikeyarce, dimadin, gonzomir, milesdelliott, warmarks, munirkamal, nfmohit, nateconley, greatislander, njpanderson, notnownikki, nielslange, nikschavan, potbot, nshki, webmandesign, oskosk, pglewis, pareshradadiya-1, swissspidy, pbearne, pauldechov, psealock, paulstonier, paulwilde, pedromendonca, ptasker, peterwilsoncc, tyrannous, strategio, piersb, delawski, prtksxna, presskopp, rachelbaker, rachelmcr, rakshans1, rahmon, lamosty, youknowriad, riddhiehta02, noisysocks, deviodigital, sanchothefat, robertsky, _dorsvenabili, rohittm, magicroundabout, rmccue, welcher, ryo511, sagarprajapati, samikeijonen, scottmweaver, kluny, sharaz, giventofly76, designsimply, sstoqnov, hypest, netweb, stevehenty, stuartfeldt, sergioestevao, soean, tammie_l, karmatosed, thrijith, timgardner, timmydcrawford, tjnowell, mirucon, travislopes, truongwp, tjfunke001, vishalkakadiya, vtrpldn, walterebert, westonruter, skorasaurus, somtijds, earnjam, williampatton, willybahuaud, yoavf, zebulan, ziyaddin, abhijitrakas, andreamiddleton, csabotta, dixitadusara, etoledom, faishal, hideokamoto, imath, iseulde, j-falk, jaswrks, johnwatkins0, jomurgel, notlaura, leahkoerper, mcsf, meetjey, 0mirka00, mitogh, ephoxmogran, tacrapo, mzorz, nagayama, omarreiss, ramonopoly, rileybrook, tinkerbelly, shaileesheth, sikander, ssousa, tfrommen, yahil.

Fixes #45037.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-admin/edit-form-blocks.php (copied) (copied from branches/5.0/src/wp-admin/edit-form-blocks.php) (3 diffs)
• src/wp-admin/post-new.php (modified) (1 diff)
• src/wp-admin/post.php (modified) (4 diffs)

trunk/src/wp-admin/edit-form-blocks.php

@@ -85 +85 @@
  */
 $initial_edits = null;
-$is_new_post = false;
+$is_new_post = false;
 if ( 'auto-draft' === $post->post_status ) {
     $is_new_post = true;
@@ -102 +102 @@
 }
 
-// Prepare Jed locale data.
-$locale_data = wp_get_jed_locale_data( 'default' );
-wp_add_inline_script(
-    'wp-i18n',
-    'wp.i18n.setLocaleData( ' . wp_json_encode( $locale_data ) . ' );'
-);
-
 // Preload server-registered block schemas.
 wp_add_inline_script(
@@ -188 +181 @@
     foreach ( $editor_styles as $style ) {
         if ( preg_match( '~^(https?:)?//~', $style ) ) {
-            //$response = wp_remote_get( $style );
-            var_dump( $response );
+            $response = wp_remote_get( $style );
             if ( ! is_wp_error( $response ) ) {
                 $styles[] = array(

trunk/src/wp-admin/post-new.php

@@ -69 +69 @@
 /** This filter is documented in wp-admin/post.php */
 if ( apply_filters( 'replace_editor', false, $post ) !== true ) {
-    wp_enqueue_script( 'autosave' );
-    include( ABSPATH . 'wp-admin/edit-form-advanced.php' );
+    if ( use_block_editor_for_post( $post ) ) {
+        include( ABSPATH . 'wp-admin/edit-form-blocks.php' );
+    } else {
+        wp_enqueue_script( 'autosave' );
+        include( ABSPATH . 'wp-admin/edit-form-advanced.php' );
+    }
 }
 

trunk/src/wp-admin/post.php

@@ -17 +17 @@
 wp_reset_vars( array( 'action' ) );
 
-if ( isset( $_GET['post'] ) && isset( $_POST['post_ID'] ) && (int) $_GET['post'] !== (int) $_POST['post_ID'] ) {
-    wp_die( __( 'A post ID mismatch has been detected.' ), __( 'Sorry, you are not allowed to edit this item.' ), 400 );
-} elseif ( isset( $_GET['post'] ) ) {
+if ( isset( $_GET['post'] ) ) {
     $post_id = $post_ID = (int) $_GET['post'];
 } elseif ( isset( $_POST['post_ID'] ) ) {
@@ -43 +41 @@
 }
 
-if ( isset( $_POST['post_type'] ) && $post && $post_type !== $_POST['post_type'] ) {
-    wp_die( __( 'A post type mismatch has been detected.' ), __( 'Sorry, you are not allowed to edit this item.' ), 400 );
-}
-
 if ( isset( $_POST['deletepost'] ) ) {
     $action = 'delete';
@@ -55 +49 @@
 $sendback = wp_get_referer();
 if ( ! $sendback ||
-    strpos( $sendback, 'post.php' ) !== false ||
-    strpos( $sendback, 'post-new.php' ) !== false ) {
+    strpos( $sendback, 'post.php' ) !== false ||
+    strpos( $sendback, 'post-new.php' ) !== false ) {
     if ( 'attachment' == $post_type ) {
         $sendback = admin_url( 'upload.php' );
@@ -173 +167 @@
         }
 
+
+
+
+
+
         if ( ! wp_check_post_lock( $post->ID ) ) {
             $active_post_lock = wp_set_post_lock( $post->ID );